Bluetooth: Fix false errors from bcsp_pkt_cull function
authorWending Weng <wweng@rheinmetall.ca>
Mon, 24 Aug 2009 20:05:17 +0000 (16:05 -0400)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 24 Aug 2009 20:32:32 +0000 (13:32 -0700)
commitd2e353f7c3c5fbb3add0341c10ae167ee745d23b
treecf84f27d7de17e941b8c1bd60b428389201aa712
parent1b7bf4edca0fdbad70c44e139f4cfebd6759de81
Bluetooth: Fix false errors from bcsp_pkt_cull function

The error message "Removed only %u out of %u pkts" is printed when multiple
to be acked packets are queued.

    if (i++ >= pkts_to_be_removed)
            break;

This will break out of the loop and increase the counter i when
i==pkts_to_be_removed and the loop ends up with i=pkts_to_be_removed+1.

The following line

    if (i != pkts_to_be_removed) {
            BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
    }

will then display the false message.

The counter i must not increase on the same statement.

Signed-off-by: Wending Weng <wweng@rheinmetall.ca>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_bcsp.c