[SCSI] target: Fix task->task_execute_queue=1 clear bug + LUN_RESET OOPs
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 20 May 2011 03:19:12 +0000 (20:19 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 27 May 2011 11:49:37 +0000 (11:49 +0000)
commitccf4d680f80941f0073a9bc6a5e0ed41496b46e7
tree33f53583b1581473b327b1399909a9217ac03684
parent42c6951e2f7a665bcb57b92fe3f806ba48152c0e
[SCSI] target: Fix task->task_execute_queue=1 clear bug + LUN_RESET OOPs

This patch fixes a bug where task->task_execute_queue=1 was not being
cleared once se_task had been removed from se_device->execute_task_list,
resulting in an OOPs in core_tmr_lun_reset() for the task->task_active=0
case where transport_remove_task_from_execute_queue() was incorrectly
being called.

This patch fixes two cases in transport_get_task_from_execute_queue()
and transport_remove_task_from_execute_queue() to properly clear
task->task_execute_queue=0 once list_del(&task->t_execute_list) has
been called.

It also adds an explict check in transport_remove_task_from_execute_queue()
to dump_stack + return if called with task->task_execute_queue=0.

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <jbottomley@parallels.com>
drivers/target/target_core_transport.c