drivers/net/wan: Use memdup_user
authorJulia Lawall <julia@diku.dk>
Fri, 21 May 2010 22:20:26 +0000 (22:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 May 2010 07:24:13 +0000 (00:24 -0700)
commitc146fc9fc9bc1dc0f629fe83d49f32ab0f11bfdc
treec7cb7c247161c9409a7f65678aa18a4543de4c7c
parentc5dc9a3581f486a738f82a5317229d494d0f475f
drivers/net/wan: Use memdup_user

Use memdup_user when user data is immediately copied into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/sdla.c