clk: cdce9xx: Fix use of dev_read_u32_default
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Fri, 25 Jul 2025 10:41:12 +0000 (11:41 +0100)
committerTom Rini <trini@konsulko.com>
Mon, 11 Aug 2025 21:11:22 +0000 (15:11 -0600)
commitbd644d9613ee0cdc3bd2ac3bc7bcc52b09d821e7
tree43231e4172df1174023d94ecd0a3cbf048a14370
parent493c3da3ac530229ca4c4caadd5df041f6c25eb2
clk: cdce9xx: Fix use of dev_read_u32_default

The function dev_read_u32_default does not return an error and the
variable 'val' is unsigned so testing for >= 0 will always be true. It
looks like the code was attempting to return -1 if xtal-load-pf was not
present but that cannot work. Instead use dev_read_u32 which returns an
error code separately from writing the value into the passed pointer.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Fixes: 260777fc2333 ("clk: cdce9xx: add support for cdce9xx clock  synthesizer")
Acked-by: Quentin Schulz <quentin.schulz@cherry.de>
drivers/clk/clk-cdce9xx.c