nbd: clear waiting_queue on shutdown
authorPaul Clements <paul.clements@steeleye.com>
Mon, 17 Sep 2012 21:09:02 +0000 (14:09 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Oct 2012 02:30:46 +0000 (03:30 +0100)
commitb641778814f791d879ba08076cb5d2fc99eb2e34
tree5b8138923e1bc0d3566ad5ecc6098dd465b405b1
parent4fa89f936f36fd98a5912a4a48497e2133cb7ff2
nbd: clear waiting_queue on shutdown

commit fded4e090c60100d709318896c79816d68d5b47d upstream.

Fix a serious but uncommon bug in nbd which occurs when there is heavy
I/O going to the nbd device while, at the same time, a failure (server,
network) or manual disconnect of the nbd connection occurs.

There is a small window between the time that the nbd_thread is stopped
and the socket is shutdown where requests can continue to be queued to
nbd's internal waiting_queue.  When this happens, those requests are
never completed or freed.

The fix is to clear the waiting_queue on shutdown of the nbd device, in
the same way that the nbd request queue (queue_head) is already being
cleared.

Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: local nbd_device pointers are called 'lo' not 'nbd']
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/block/nbd.c