drivers/misc/bh1770glc.c: error handling in bh1770_power_state_store()
authorDan Carpenter <error27@gmail.com>
Thu, 11 Nov 2010 22:05:13 +0000 (14:05 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 12 Nov 2010 15:55:31 +0000 (07:55 -0800)
commitaec04288904a7308f2900926902040e7a69ae2be
treedc897e5ee40107d92216a930494138a12706eb95
parentd2e61b8dc99fdb36e0fd176e25365f69afda4ff9
drivers/misc/bh1770glc.c: error handling in bh1770_power_state_store()

There was a signedness bug so "ret" was never less than zero and that
breaks the error handling.  Also in the original code it would overwrite
ret and the result is still negative but it's bogus number instead of the
correct error code.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/misc/bh1770glc.c