iommu/vt-d: fix memory leakage caused by commit ea8ea46
authorJiang Liu <jiang.liu@linux.intel.com>
Wed, 9 Apr 2014 02:20:39 +0000 (10:20 +0800)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Sun, 13 Apr 2014 12:07:56 +0000 (13:07 +0100)
commitadeb25905c644350baf1f446bcd856517e58060e
tree1ce3d39a0761c3cf12c562128c605af7bb3cbb8f
parent7713ec066ae8adc49dd8daa02a73e6b60af6ee5f
iommu/vt-d: fix memory leakage caused by commit ea8ea46

Commit ea8ea46 "iommu/vt-d: Clean up and fix page table clear/free
behaviour" introduces possible leakage of DMA page tables due to:
        for (pte = page_address(pg); !first_pte_in_page(pte); pte++) {
                if (dma_pte_present(pte) && !dma_pte_superpage(pte))
                        freelist = dma_pte_list_pagetables(domain, level - 1,
                                                           pte, freelist);
        }

For the first pte in a page, first_pte_in_page(pte) will always be true,
thus dma_pte_list_pagetables() will never be called and leak DMA page
tables if level is bigger than 1.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/iommu/intel-iommu.c