drivers/video/bfin-lq035q1-fb.c: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Fri, 1 Apr 2011 14:23:47 +0000 (14:23 +0000)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 6 Apr 2011 16:44:57 +0000 (09:44 -0700)
commita8c908d353e52336b864025dbd8253134c3f5411
treea94cf9d1774028e08803f14fdd07819d139d5899
parentb73a21fc66fee35b41db755abebfacba48b2fc76
drivers/video/bfin-lq035q1-fb.c: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/video/bfin-lq035q1-fb.c