iscsi-target: Always send a response before terminating iSCSI connection
authorRoland Dreier <roland@purestorage.com>
Tue, 6 Nov 2012 02:02:42 +0000 (18:02 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 3 Jan 2013 03:33:03 +0000 (03:33 +0000)
commit9ef928b0104af7c05b03f6a40bffe225b4f4c9e4
tree9ab8f6a1131562901a3938bd5f969b2c4b341b3e
parent74dd89a8b70467b6cc5078c03c9de1721717aef0
iscsi-target: Always send a response before terminating iSCSI connection

commit 1c5c12c666fda27c7c494b34934a0a0631a48130 upstream.

There are some cases, for example when the initiator sends an
out-of-bounds ErrorRecoveryLevel value, where the iSCSI target
terminates the connection without sending back any error.  Audit the
login path and add appropriate iscsit_tx_login_rsp() calls to make
sure this doesn't happen.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/target/iscsi/iscsi_target_login.c
drivers/target/iscsi/iscsi_target_nego.c