ipvs: Remove unused variable ret from sync_thread_master()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Tue, 12 Nov 2013 14:34:24 +0000 (15:34 +0100)
committerSimon Horman <horms@verge.net.au>
Fri, 27 Dec 2013 03:19:32 +0000 (12:19 +0900)
commit9dcbe1b87c4a8e3ed62e95369c18709541a3dc8f
tree89b6dc4b6105aec2f2eccdbb36cb39a0e7dc3fb4
parent6a649f339802f104549e1fb211e381036661e244
ipvs: Remove unused variable ret from sync_thread_master()

net/netfilter/ipvs/ip_vs_sync.c: In function 'sync_thread_master':
net/netfilter/ipvs/ip_vs_sync.c:1640:8: warning: unused variable 'ret' [-Wunused-variable]

Commit 35a2af94c7ce7130ca292c68b1d27fcfdb648f6b ("sched/wait: Make the
__wait_event*() interface more friendly") changed how the interruption
state is returned. However, sync_thread_master() ignores this state,
now causing a compile warning.

According to Julian Anastasov <ja@ssi.bg>, this behavior is OK:

    "Yes, your patch looks ok to me. In the past we used ssleep() but IPVS
     users were confused why IPVS threads increase the load average. So, we
     switched to _interruptible calls and later the socket polling was
     added."

Document this, as requested by Peter Zijlstra, to avoid precious developers
disappearing in this pitfall in the future.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
net/netfilter/ipvs/ip_vs_sync.c