act_mirred: do not drop packets when fails to mirror it
authorJason Wang <jasowang@redhat.com>
Wed, 15 Aug 2012 20:44:27 +0000 (20:44 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 9 Jun 2014 12:28:59 +0000 (13:28 +0100)
commit9a45de4b54dc3e6ecbdc1f4d0d15dcbd2410bad3
tree3b8b3fcbebfdcef3e66668a34fb527b9ec600f44
parent5b64df7dd898e1b05ecb77d06a69313a9d7c43db
act_mirred: do not drop packets when fails to mirror it

[ Upstream commit 16c0b164bd24d44db137693a36b428ba28970c62 ]

We drop packet unconditionally when we fail to mirror it. This is not intended
in some cases. Consdier for kvm guest, we may mirror the traffic of the bridge
to a tap device used by a VM. When kernel fails to mirror the packet in
conditions such as when qemu crashes or stop polling the tap, it's hard for the
management software to detect such condition and clean the the mirroring
before. This would lead all packets to the bridge to be dropped and break the
netowrk of other virtual machines.

To solve the issue, the patch does not drop packets when kernel fails to mirror
it, and only drop the redirected packets.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/sched/act_mirred.c