drbd: fix schedule in atomic
authorLars Ellenberg <lars.ellenberg@linbit.com>
Mon, 2 May 2011 09:51:31 +0000 (11:51 +0200)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Tue, 24 May 2011 08:14:32 +0000 (10:14 +0200)
commit9a0d9d0389ef769e4b01abf50fcc11407706270b
treee766296ff1e684a0a081a6961ec664a4131faf74
parent99432fcc528d7a5ac8494a4c07ad4726670c96e2
drbd: fix schedule in atomic

An administrative detach used to request a state change directly to D_DISKLESS,
first suspending IO to avoid the last put_ldev() occuring from an endio handler,
potentially in irq context.

This is not enough on the receiving side (typically secondary), we may miss
some peer_req on the way to local disk, which then may do the last put_ldev()
from their drbd_peer_request_endio().

This patch makes the detach always go through the intermediate D_FAILED state.
We may consider to rename it D_DETACHING.

Alternative approach would be to create yet an other work item to be scheduled
on the worker, do the destructor work from there, and get the timing right.

manually picked commit 564040f from the drbd 8.4 branch.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_int.h
drivers/block/drbd/drbd_nl.c
include/linux/drbd.h