Revert "ARM: imx: add FEC sleep mode callback function"
authorFabio Estevam <fabio.estevam@freescale.com>
Wed, 7 Jan 2015 12:39:52 +0000 (10:39 -0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Jan 2015 04:05:19 +0000 (20:05 -0800)
commit99b164a66b7c80be69097d19e55dd1f6a5284fd6
tree1d109731d6d603c892abdf34a6f16836d51c7c65
parent0bec3b700d106a8b0a34227b2976d1a582f1aab7
Revert "ARM: imx: add FEC sleep mode callback function"

i.MX platform maintainer Shawn Guo is not happy with the such commit as
explained below [1]:

"The GPR difference between SoCs can be encoded in device tree as well.
It's pointless to repeat the same code pattern for every single
platform, that need to set up GPR bits for enabling magic packet wake
up, while the only difference is the register and bit offset.

The platform code will become quite messy and unmaintainable if every
device driver dump their GPR register setup code into platform.

Sorry, but it's NACK from me."

This reverts commit 456062b3ec6f5b9 ("ARM: imx: add FEC sleep mode callback
function").

[1] http://www.spinics.net/lists/netdev/msg310922.html

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/arm/mach-imx/mach-imx6q.c
arch/arm/mach-imx/mach-imx6sx.c