rtlwifi: rtl8192cu: Fix duplicate if test
authorLarry Finger <Larry.Finger@lwfinger.net>
Tue, 18 Jun 2013 18:25:05 +0000 (13:25 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 27 Jul 2013 04:34:13 +0000 (05:34 +0100)
commit965386e5345230cb27d840a272c3a5fe78fb9da7
treea55bb4f846552f101d2c8ceec256de81c9649397
parent2af951daef68fcb1c6cace0543c420a8c26fe756
rtlwifi: rtl8192cu: Fix duplicate if test

commit 10d0b9030a3f86e1e26c710c7580524d7787d688 upstream.

A typo causes routine rtl92cu_phy_rf6052_set_cck_txpower() to test the
same condition twice. The problem was found using cppcheck-1.49, and the
proper fix was verified against the pre-mac80211 version of the code.

This patch was originally included as commit 1288aa4, but was accidentally
reverted in a later patch.

Reported-by: David Binderman <dcb314@hotmail.com> [original report]
Reported-by: Andrea Morello <andrea.merello@gmail.com> [report of accidental reversion]
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/rtlwifi/rtl8192cu/rf.c