HID: hiddev: potential info leak in hiddev_ioctl()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 23 Sep 2011 06:21:13 +0000 (09:21 +0300)
committerJiri Kosina <jkosina@suse.cz>
Mon, 26 Sep 2011 23:33:10 +0000 (01:33 +0200)
commit9561f7faa45cb855b1ba83a4acf3f2ad3665e71f
tree89138048c81d60f29a1cc605c2aae679bdeb4850
parent65b01bd561dc995aab116aa784f97a37f7c49a65
HID: hiddev: potential info leak in hiddev_ioctl()

Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.

In this case, the hiddev_devinfo struct has a two byte hole.

struct hiddev_devinfo {
        __u32                      bustype;              /*     0     4 */
        __u32                      busnum;               /*     4     4 */
        __u32                      devnum;               /*     8     4 */
        __u32                      ifnum;                /*    12     4 */
        __s16                      vendor;               /*    16     2 */
        __s16                      product;              /*    18     2 */
        __s16                      version;              /*    20     2 */

        /* XXX 2 bytes hole, try to pack */

        __u32                      num_applications;     /*    24     4 */

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hiddev.c