tracing/ksym_tracer: fix write operation of ksym_trace_filter
authorXiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Wed, 22 Jul 2009 03:23:41 +0000 (11:23 +0800)
committerSteven Rostedt <rostedt@goodmis.org>
Fri, 24 Jul 2009 00:52:05 +0000 (20:52 -0400)
commit8e068542a8d9efec55126284d2f5cb32f003d507
treeb3a75ae9a2dd27596bda9f1c7be1cd5ce0ebacfe
parentd857ace143df3884954887e1899a65831ca72ece
tracing/ksym_tracer: fix write operation of ksym_trace_filter

This patch fix 2 bugs:
- fix the return value of ksym_trace_filter_write() when we want to
  clear symbol in ksym_trace_filter file
  for example:
  # echo global_trace:rw- > /debug/tracing/ksym_trace_filter
  # echo global_trace:--- > /debug/tracing/ksym_trace_filter
  -bash: echo: write error: Invalid argument
  # cat /debug/tracing/ksym_trace_filter
  #
  We want to clear 'global_trace' in ksym_trace_filter, it complain
  with "Invalid argument", but the operation is successful

- the "r--" access types is not allowed, but ksym_trace_filter file think
  it OK
  for example:
  # echo ksym_tracer_mutex:r-- > ksym_trace_filter
  -bash: echo: write error: Resource temporarily unavailable
  # dmesg
  ksym_tracer request failed. Try again later!!

  The error occur at register_kernel_hw_breakpoint(), but It's should
  at access types parser

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
LKML-Reference: <4A66863D.5090802@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_ksym.c