ext4: fix memory leak in ext4_xattr_set_acl()'s error path
authorEugene Shatokhin <eugene.shatokhin@rosalab.ru>
Thu, 8 Nov 2012 20:11:11 +0000 (15:11 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 3 Jan 2013 03:33:03 +0000 (03:33 +0000)
commit8c1efde2eac55d2151f450aee718d8cdf0e72da0
tree90163a07786c49ce44805cf89908fff1d4e1d435
parent9ef928b0104af7c05b03f6a40bffe225b4f4c9e4
ext4: fix memory leak in ext4_xattr_set_acl()'s error path

commit 24ec19b0ae83a385ad9c55520716da671274b96c upstream.

In ext4_xattr_set_acl(), if ext4_journal_start() returns an error,
posix_acl_release() will not be called for 'acl' which may result in a
memory leak.

This patch fixes that.

Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/acl.c