fs/squashfs: Ensure memory is freed by using unwind goto
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Thu, 2 Oct 2025 10:36:09 +0000 (11:36 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 10 Oct 2025 20:27:49 +0000 (14:27 -0600)
commit87b7eaf3244e1a991404602c3422a4ce06bfae55
treeedd050a7de09664f8dcd97a28f97c8023278a3d9
parent42b353412517ecfc9ba93dcd7f31e0e3557af413
fs/squashfs: Ensure memory is freed by using unwind goto

Returning immediately from sqfs_read_nest is not consistent with other
error checks in this function and can lead to memory leaks. Instead use
the unwind goto used elsewhere to ensure that the memory is freed.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Acked-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
fs/squashfs/sqfs.c