git.openpandora.org / pandora-u-boot.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a948f57) | patch
smbios: Do not look up children of invalid nodes
authorSamuel Holland <samuel.holland@sifive.com>
Mon, 14 Apr 2025 19:47:04 +0000 (12:47 -0700)
committerTom Rini <trini@konsulko.com>
Thu, 24 Apr 2025 14:23:02 +0000 (08:23 -0600)
commit8327aa9af4be32b4236dfd25c8cefe568e9b3641
tree025360246604f6b0a164312d2be212ef40bb1886tree | snapshot
parenta948f5711844498421432719c4c19d9629cb9c05commit | diff
smbios: Do not look up children of invalid nodes

If there is no UCLASS_SYSINFO device available, parent_node will be
ofnode_null(). Calling ofnode_find_subnode() then triggers an assertion:

  drivers/core/ofnode.c:598: ofnode_find_subnode: Assertion `ofnode_valid(node)' failed.

Check for a valid parent_node, not just that OF_CONTROL is enabled.

Fixes: 44ffb6f0ecaf ("smbios: Allow properties to come from the device tree")
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
lib/smbios.c diff | blob | history
Pandora U-Boot Repository