usb: don't use PREPARE_DELAYED_WORK
authorTejun Heo <tj@kernel.org>
Fri, 7 Mar 2014 15:24:48 +0000 (10:24 -0500)
committerTejun Heo <tj@kernel.org>
Fri, 7 Mar 2014 15:24:48 +0000 (10:24 -0500)
commit77fa83cf7478202fac1520ca082ab8f9658d63b4
tree13c4b03a5f416f78ef95396600ec09f30622a7c0
parent75ddb38f0901d12831264cd74224598e4d8f528b
usb: don't use PREPARE_DELAYED_WORK

PREPARE_[DELAYED_]WORK() are being phased out.  They have few users
and a nasty surprise in terms of reentrancy guarantee as workqueue
considers work items to be different if they don't have the same work
function.

usb_hub->init_work is multiplexed with multiple work functions;
however, the work item is never queued while in-flight, so we can
simply use INIT_DELAYED_WORK() before each queueing.

It would probably be best to route this with other related updates
through the workqueue tree.

Lightly tested.

v2: Greg and Alan confirm that the work item is never queued while
    in-flight.  Simply use INIT_DELAYED_WORK().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org
drivers/usb/core/hub.c