sched: Revert need_resched() to look at TIF_NEED_RESCHED
authorPeter Zijlstra <peterz@infradead.org>
Fri, 27 Sep 2013 15:30:03 +0000 (17:30 +0200)
committerIngo Molnar <mingo@kernel.org>
Sat, 28 Sep 2013 08:04:47 +0000 (10:04 +0200)
commit75f93fed50c2abadbab6ef546b265f51ca975b27
treeae531501cb671c948baedb8e07111f8dda2d5036
parent1a338ac32ca630f67df25b4a16436cccc314e997
sched: Revert need_resched() to look at TIF_NEED_RESCHED

Yuanhan reported a serious throughput regression in his pigz
benchmark. Using the ftrace patch I found that several idle
paths need more TLC before we can switch the generic
need_resched() over to preempt_need_resched.

The preemption paths benefit most from preempt_need_resched and
do indeed use it; all other need_resched() users don't really
care that much so reverting need_resched() back to
tif_need_resched() is the simple and safe solution.

Reported-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: lkp@linux.intel.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20130927153003.GF15690@laptop.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/preempt.h
include/asm-generic/preempt.h
include/linux/sched.h