dm btree: fix bufio buffer leaks in dm_btree_del() error path
authorJoe Thornber <ejt@redhat.com>
Thu, 10 Dec 2015 14:37:53 +0000 (14:37 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 Dec 2015 02:26:01 +0000 (02:26 +0000)
commit715b56f753f736b6b701e402f22e8d5a41471f1b
treeab87405b9e3d379fb05cdef777920a7b17ca2428
parent207ffa8cbcf6e780d862316a94c95a7e70d1e72e
dm btree: fix bufio buffer leaks in dm_btree_del() error path

commit ed8b45a3679eb49069b094c0711b30833f27c734 upstream.

If dm_btree_del()'s call to push_frame() fails, e.g. due to
btree_node_validator finding invalid metadata, the dm_btree_del() error
path must unlock all frames (which have active dm-bufio buffers) that
were pushed onto the del_stack.

Otherwise, dm_bufio_client_destroy() will BUG_ON() because dm-bufio
buffers have leaked, e.g.:
  device-mapper: bufio: leaked buffer 3, hold count 1, list 0

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/persistent-data/dm-btree.c