pinctrl: zynqmp: Avoid using uninitialised variable
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Thu, 7 Aug 2025 10:04:05 +0000 (11:04 +0100)
committerMichal Simek <michal.simek@amd.com>
Mon, 25 Aug 2025 14:20:47 +0000 (16:20 +0200)
commit6ce599f513172147362e8a2f7424837a2dd60e90
treec37ac80f7c6777907a1abff19343c8f4d6905f59
parent7aac8439445793baa9313a7d5139b77f968b2885
pinctrl: zynqmp: Avoid using uninitialised variable

In zynqmp_pinconf_set if param is PIN_CFG_IOSTANDARD or
PIN_CONFIG_POWER_SOURCE and zynqmp_pm_pinctrl_get_config returns an
error then value will not be assigned to when its value is tested to be
not equal to arg. Add code to only test value not equal to arg if ret is
false.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Link: https://lore.kernel.org/r/20250807-pinctrl_misc-v1-4-eeb564a1b032@linaro.org
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/pinctrl/pinctrl-zynqmp.c