RDMA/iwcm: Don't touch cm_id after deref in rem_ref
authorSteve Wise <swise@opengridcomputing.com>
Thu, 21 Nov 2013 21:40:14 +0000 (15:40 -0600)
committerRoland Dreier <roland@purestorage.com>
Mon, 16 Dec 2013 00:47:47 +0000 (16:47 -0800)
commit6b59ba609bb61e4fa2ecca7827f170ac07842d64
treecb7f4cc3a619bf13bc01f0f7175e7f61c36ec9d6
parent374b105797c3d4f29c685f3be535c35f5689b30e
RDMA/iwcm: Don't touch cm_id after deref in rem_ref

rem_ref() calls iwcm_deref_id(), which will wake up any blockers on
cm_id_priv->destroy_comp if the refcnt hits 0.  That will unblock
someone in iw_destroy_cm_id() which will free the cmid.  If that
happens before rem_ref() calls test_bit(IWCM_F_CALLBACK_DESTROY,
&cm_id_priv->flags), then the test_bit() will touch freed memory.

The fix is to read the bit first, then deref.  We should never be in
iw_destroy_cm_id() with IWCM_F_CALLBACK_DESTROY set, and there is a
BUG_ON() to make sure of that.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/core/iwcm.c