sched: Fix balance vs hotplug race
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Wed, 25 Nov 2009 12:31:39 +0000 (13:31 +0100)
committerIngo Molnar <mingo@elte.hu>
Sun, 6 Dec 2009 20:10:56 +0000 (21:10 +0100)
commit6ad4c18884e864cf4c77f9074d3d1816063f99cd
treef09643f6148b576fa2d23bf7d4b37d082d94e267
parente1b8090bdf125f8b2e192149547fead7f302a89c
sched: Fix balance vs hotplug race

Since (e761b77: cpu hotplug, sched: Introduce cpu_active_map and redo
sched domain managment) we have cpu_active_mask which is suppose to rule
scheduler migration and load-balancing, except it never (fully) did.

The particular problem being solved here is a crash in try_to_wake_up()
where select_task_rq() ends up selecting an offline cpu because
select_task_rq_fair() trusts the sched_domain tree to reflect the
current state of affairs, similarly select_task_rq_rt() trusts the
root_domain.

However, the sched_domains are updated from CPU_DEAD, which is after the
cpu is taken offline and after stop_machine is done. Therefore it can
race perfectly well with code assuming the domains are right.

Cure this by building the domains from cpu_active_mask on
CPU_DOWN_PREPARE.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/cpumask.h
kernel/cpu.c
kernel/cpuset.c
kernel/sched.c