cgroup: notify_on_release may not be triggered in some cases
authorDaisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Thu, 4 Oct 2012 07:37:16 +0000 (16:37 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 30 Oct 2012 23:26:48 +0000 (23:26 +0000)
commit66a0d04ab3977f62ae3dcec25bd6df4a830cd02c
tree004bbd148c734e09b3e5d9cccb21aa4a617f0ed0
parent735dbc9e51ae26e10eb3a0f277cfd2d81ca675bb
cgroup: notify_on_release may not be triggered in some cases

commit 1f5320d5972aa50d3e8d2b227b636b370e608359 upstream.

notify_on_release must be triggered when the last process in a cgroup is
move to another. But if the first(and only) process in a cgroup is moved to
another, notify_on_release is not triggered.

# mkdir /cgroup/cpu/SRC
# mkdir /cgroup/cpu/DST
#
# echo 1 >/cgroup/cpu/SRC/notify_on_release
# echo 1 >/cgroup/cpu/DST/notify_on_release
#
# sleep 300 &
[1] 8629
#
# echo 8629 >/cgroup/cpu/SRC/tasks
# echo 8629 >/cgroup/cpu/DST/tasks
-> notify_on_release for /SRC must be triggered at this point,
   but it isn't.

This is because put_css_set() is called before setting CGRP_RELEASABLE
in cgroup_task_migrate(), and is a regression introduce by the
commit:74a1166d(cgroups: make procs file writable), which was merged
into v3.0.

Cc: Ben Blum <bblum@andrew.cmu.edu>
Acked-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Signed-off-by: Tejun Heo <tj@kernel.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/cgroup.c