xfs: kill xfs_fs_repair_cmn_err() macro
authorDave Chinner <dchinner@redhat.com>
Sun, 6 Mar 2011 23:03:35 +0000 (10:03 +1100)
committerDave Chinner <david@fromorbit.com>
Sun, 6 Mar 2011 23:03:35 +0000 (10:03 +1100)
commit65333b4c3d46909872796321d15f179cb0e32028
tree8273ccd922f1b9f977b9223636bdd018d977c16a
parent6a19d9393a5402e69fc52f5da8a828b8499a8265
xfs: kill xfs_fs_repair_cmn_err() macro

In certain cases of inode corruption, the xfs_fs_repair_cmn_err()
macro is used to output an extra message in the corruption report.
That extra message is "unmount and run xfs_repair", which really
applies to any corruption report. Each case that this macro is
called (except one) a following call to xfs_corruption_error() is
made to optionally dump more information about the error.

Hence, move the output of "run xfs_repair" to xfs_corruption_error()
so that it is output on all corruption reports.  Also, convert the
callers of the repair macro that don't call xfs_corruption_error()
to call it, hence provide consiŃ•tent error reporting for all cases
where xfs_fs_repair_cmn_err() used to be called.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/xfs_bmap.c
fs/xfs/xfs_error.c
fs/xfs/xfs_error.h
fs/xfs/xfs_inode.c