uas: Simplify unlink of data urbs on error
authorHans de Goede <hdegoede@redhat.com>
Sat, 13 Sep 2014 10:26:34 +0000 (12:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Sep 2014 04:42:10 +0000 (21:42 -0700)
commit60d9f67d478e7c8ed09e3a6888b29aca2d978979
tree10096e48239cf0482a9a77e9c828912ea5c2fd68
parentd89da03acec19b39506f3ef32e09134b50b4adb9
uas: Simplify unlink of data urbs on error

There is no need for all the trickery with dropping the lock, we can
simply reference the urbs while we hold the lock to ensure the urbs don't
disappear beneath us, and do the actual unlink (+ unreference) after we've
dropped the lock.

This also fixes a race where we may loose of cmnd ownership to the scsi
midlayer without holding the lock due to the midlayer re-claiming ownership
through an abort (which will be handled by a future patch in this series).

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/uas.c