[SCSI] bnx2fc: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Fri, 1 Apr 2011 14:23:46 +0000 (16:23 +0200)
committerJames Bottomley <James.Bottomley@suse.de>
Sun, 1 May 2011 15:18:31 +0000 (10:18 -0500)
commit5c2dce26fd670607b5ff04f18efa38739805f6d6
tree0664c48fd5610e2905ab849f088f3abeab75ee62
parentab6c10b136d5f8eb856a0f17247edc7c19805e1b
[SCSI] bnx2fc: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/bnx2fc/bnx2fc_hwi.c