ext4: fix data corruption in data=journal mode
authorJan Kara <jack@suse.cz>
Fri, 27 Jan 2017 19:35:38 +0000 (14:35 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:45 +0000 (21:13 +0100)
commit56809722764c76f0383dc3be872bca1cfa59c8d9
treee5a3e0732878ddb04f139fc4cdfd53d494230fc4
parentec7d1dbf6dda4f536dbafa966fb111b653948f07
ext4: fix data corruption in data=journal mode

commit 3b136499e906460919f0d21a49db1aaccf0ae963 upstream.

ext4_journalled_write_end() did not propely handle all the cases when
generic_perform_write() did not copy all the data into the target page
and could mark buffers with uninitialized contents as uptodate and dirty
leading to possible data corruption (which would be quickly fixed by
generic_perform_write() retrying the write but still). Fix the problem
by carefully handling the case when the page that is written to is not
uptodate.

Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/inode.c