packet: call fanout_release, while UNREGISTERING a netdev
authorAnoob Soman <anoob.soman@citrix.com>
Wed, 5 Oct 2016 14:12:54 +0000 (15:12 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 16 Mar 2017 02:18:50 +0000 (02:18 +0000)
commit4d872cbe0cdebf17079a8dd509e557a5baea7044
tree3a43738ef7ec580468ee57fe862862683e6a641c
parentda3fd21425e51e65b20903fd7176e16bfb8e6c3d
packet: call fanout_release, while UNREGISTERING a netdev

commit 6664498280cf17a59c3e7cf1a931444c02633ed1 upstream.

If a socket has FANOUT sockopt set, a new proto_hook is registered
as part of fanout_add(). When processing a NETDEV_UNREGISTER event in
af_packet, __fanout_unlink is called for all sockets, but prot_hook which was
registered as part of fanout_add is not removed. Call fanout_release, on a
NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the
fanout_list.

This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo()

Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/packet/af_packet.c