pch_uart: Fix dma channel unallocated issue
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Thu, 12 Apr 2012 01:47:50 +0000 (10:47 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:00 +0000 (13:14 +0100)
commit493fe64b95d87298d19d5390f82d822ff37cc38d
tree49bfe83b9d40653a833f95cedf48e648594c125a
parent022666433f5a7f8bf7e075ab4814061a824dd236
pch_uart: Fix dma channel unallocated issue

commit af6d17cdc8c89aeb3101f0d27cd32fc0592b40b2 upstream.

This driver anticipates pch_uart_verify_port() is not called
during installation.
However, actually pch_uart_verify_port() is called during
installation.
As a result, memory access violation occurs like below.

0. initial value: use_dma=0
1. starup()
    - dma channel is not allocated because use_dma=0
2. pch_uart_verify_port()
    - Set use_dma=1
3. UART processing acts DMA mode because use_dma=1
     - memory access violation occurs!

This patch fixes the issue.

Solution:
Whenever pch_uart_verify_port() is called and then
dma channel is not allocated, the channel should be allocated.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/tty/serial/pch_uart.c