lockdep/timers: Explain in detail the locking problems del_timer_sync() may cause
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 8 Feb 2011 17:39:54 +0000 (12:39 -0500)
committerIngo Molnar <mingo@elte.hu>
Wed, 16 Feb 2011 12:35:08 +0000 (13:35 +0100)
commit48228f7b470a74b6469a250d2977a13128d8fe96
tree1ed8f82ffef779ccf665f68c1fcf302d34d09826
parenta3ec4a603faf4244e275bf11b467aad092dfbd8a
lockdep/timers: Explain in detail the locking problems del_timer_sync() may cause

Twice I had to explain the output about why lockdep gives an error with
locks in IRQ context and with del_timer_sync(). Might as well write it
up and place it in the comments above the code in del_timer_sync().
Perhaps the next time this lockdep dump triggers people will understand
the issues.

It is a ticky issue and very subtle, explaining it in detail in the code
may help others understand the issue when they stumble upon the bug
again.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1297186794.23343.19.camel@gandalf.stny.rr.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/timer.c