vfs: Avoid softlockups with sendfile(2)
authorJan Kara <jack@suse.cz>
Mon, 23 Nov 2015 12:09:51 +0000 (13:09 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 Dec 2015 02:25:58 +0000 (02:25 +0000)
commit47ae562efbd0fd8440959304915291865b945c67
treed259992d55d37cd5aa77693744b2bdf2b5665b0f
parent353f5a95e58fa117fdda7f376020ecd85fb7444a
vfs: Avoid softlockups with sendfile(2)

commit c2489e07c0a71a56fb2c84bc0ee66cddfca7d068 upstream.

The following test program from Dmitry can cause softlockups or RCU
stalls as it copies 1GB from tmpfs into eventfd and we don't have any
scheduling point at that path in sendfile(2) implementation:

        int r1 = eventfd(0, 0);
        int r2 = memfd_create("", 0);
        unsigned long n = 1<<30;
        fallocate(r2, 0, 0, n);
        sendfile(r1, r2, 0, n);

Add cond_resched() into __splice_from_pipe() to fix the problem.

CC: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/splice.c