sfc: Avoid generating over-length MC_CMD_FLUSH_RX_QUEUES request
authorBen Hutchings <bhutchings@solarflare.com>
Wed, 19 Sep 2012 01:53:34 +0000 (02:53 +0100)
committerBen Hutchings <bhutchings@solarflare.com>
Wed, 19 Sep 2012 01:56:25 +0000 (02:56 +0100)
commit450783747f42dfa3883920acfad4acdd93ce69af
treee6b4b03dedec04576730c456494b36b3f27d97d5
parent25ce200215666956d96d1a62a20c75a2f3b9d38e
sfc: Avoid generating over-length MC_CMD_FLUSH_RX_QUEUES request

MCDI supports requests up to 252 bytes long, which is only enough to
pass 63 RX queue IDs to MC_CMD_FLUSH_RX_QUEUES.  However a VF may have
up to 64 RX queues, and if we try to flush them all we will generate
an over-length request and BUG() in efx_mcdi_copyin().  Currently
all VF drivers limit themselves to 32 RX queues, so reducing the
limit to 63 does no harm.

Also add a BUILD_BUG_ON in efx_mcdi_flush_rxqs() so we remember to
deal with the same problem there if EFX_MAX_CHANNELS is increased.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/ethernet/sfc/mcdi.c
drivers/net/ethernet/sfc/siena_sriov.c