ARM: 6987/1: l2x0: fix disabling function to avoid deadlock
authorWill Deacon <will.deacon@arm.com>
Fri, 1 Jul 2011 13:36:19 +0000 (14:36 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Wed, 6 Jul 2011 19:48:08 +0000 (20:48 +0100)
commit38a8914f9ac2379293944f613e6ca24b61373de8
tree2e414d49cb202c610899b8871626fb9eda580452
parent186dcaa448c0a7a99933efac2af225fc4fe82c53
ARM: 6987/1: l2x0: fix disabling function to avoid deadlock

The l2x0_disable function attempts to writel with the l2x0_lock held.
This results in deadlock when the writel contains an outer_sync call
for the platform since the l2x0_lock is already held by the disable
function. A further problem is that disabling the L2 without flushing it
first can lead to the spin_lock operation becoming visible after the
spin_unlock, causing any subsequent L2 maintenance to deadlock.

This patch replaces the writel with a call to writel_relaxed in the
disabling code and adds a flush before disabling in the control
register, preventing livelock from occurring.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mm/cache-l2x0.c