tg3: Fix link check in tg3_adjust_link
authorMatt Carlson <mcarlson@broadcom.com>
Wed, 22 Feb 2012 12:35:18 +0000 (12:35 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Feb 2012 06:57:17 +0000 (01:57 -0500)
commit34655ad63893d3dd64f3fbaaaa0791550e554fa9
tree15e0fab7a17f7fecb372224792dff46ba76e3c30
parent9f6f9af7694ede6314bed281eec74d588ba9474f
tg3: Fix link check in tg3_adjust_link

The tg3 driver tried to detect link changes by comparing the tg3 local
active_speed member with SPEED_UNKNOWN (or formerly SPEED_INVALID).
This check is not correct, since phylib will never set its speed member
to either of these two values.  The code only appeared to work because
tg3 initializes active_speed to SPEED_INVALID during tg3_init_one.  This
patch introduces a new "old_link" tg3 member and then compares the
phy_device's link member against it to detect link state changes.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/broadcom/tg3.h