media: dmxdev: remove dvb_ringbuffer_flush() on writer side
authorSoeren Moch <smoch@web.de>
Thu, 6 Jun 2013 00:26:23 +0000 (21:26 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 27 Jul 2013 04:34:13 +0000 (05:34 +0100)
commit2af951daef68fcb1c6cace0543c420a8c26fe756
tree360eaf6edd44769c8cbc5ee03ae93290962ed3d8
parente4af376d04b03ff3ab2f27701bb183da6ee2aaff
media: dmxdev: remove dvb_ringbuffer_flush() on writer side

commit 414abbd2cd4c2618895f02ed3a76ec6647281436 upstream.

In dvb_ringbuffer lock-less synchronizationof reader and writer threads is done
with separateread and write pointers. Sincedvb_ringbuffer_flush() modifies the
read pointer, this function must not be called from the writer thread.
This patch removes the dvb_ringbuffer_flush() calls in the dmxdev ringbuffer
write functions, this fixes Oopses "Unable to handle kernel paging request"
I could observe for the call chaindvb_demux_read ->dvb_dmxdev_buffer_read ->
dvb_ringbuffer_read_user -> __copy_to_user (the reader side of the ringbuffer).
The flush calls at the write side are not necessary anyway since ringbuffer_flush
is also called in dvb_dmxdev_buffer_read() when an error condition is set in the
ringbuffer.
This patch should also be applied to stable kernels.

Signed-off-by: Soeren Moch <smoch@web.de>
Reviewed-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/media/dvb/dvb-core/dmxdev.c