Bluetooth: RFCOMM - Fix info leak in ioctl(RFCOMMGETDEVLIST)
authorMathias Krause <minipli@googlemail.com>
Wed, 15 Aug 2012 11:31:49 +0000 (11:31 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 19 Sep 2012 14:04:52 +0000 (15:04 +0100)
commit2ab341d741cb33f5e69893f6871cf4a4d7bfd3f5
tree8f4af96a49418e7a6d57e860e1226b52dbbb2b1e
parent1621af48f4c2cf3e10438507bea36af7189603b9
Bluetooth: RFCOMM - Fix info leak in ioctl(RFCOMMGETDEVLIST)

[ Upstream commit f9432c5ec8b1e9a09b9b0e5569e3c73db8de432a ]

The RFCOMM code fails to initialize the two padding bytes of struct
rfcomm_dev_list_req inserted for alignment before copying it to
userland. Additionally there are two padding bytes in each instance of
struct rfcomm_dev_info. The ioctl() that for disclosures two bytes plus
dev_num times two bytes uninitialized kernel heap memory.

Allocate the memory using kzalloc() to fix this issue.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/bluetooth/rfcomm/tty.c