sh: Fix TCP payload csum bug in csum_partial_copy_generic().
authorOllie Wild <aaw@rincewind.tv>
Wed, 27 Sep 2006 05:46:24 +0000 (14:46 +0900)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 27 Sep 2006 05:46:24 +0000 (14:46 +0900)
commit24ab54cb49c099d691c68fdd1ac6a0c2f5177da4
treea75607c77faadb28a994a056469165386406a8e4
parent8b395265f81817385f12e62f03f795efb732a445
sh: Fix TCP payload csum bug in csum_partial_copy_generic().

There's a bug in the Hitachi SuperH csum_partial_copy_generic()
implementation.  If the supplied length is 1 (and several alignment
conditions are met), the function immediately branches to label 4.
However, the assembly at label 4 expects the length to be stored in
register r2.  Since this has not occurred, subsequent behavior is
undefined.

This can cause bad payload checksums in TCP connections.

I've fixed the problem by initializing register r2 prior to the branch
instruction.

Signed-off-by: Ollie Wild <aaw@rincewind.tv>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
arch/sh/lib/checksum.S