git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b625a82) | patch
firewire: sbp2: remove redundant check for bidi command
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 23 Jan 2015 14:05:13 +0000 (15:05 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 31 Jan 2015 14:27:40 +0000 (15:27 +0100)
commit1f95f8c9fddb14ec0c5b2d49f691b9c2aee7b9b9
tree80945f8cc50af45e52122b31b21adf59d84a9e6ctree | snapshot
parentb625a825955ede39047e821f4b69f36cf042b952commit | diff
firewire: sbp2: remove redundant check for bidi command

[Bart van Asche:]  SCSI core never sets cmd->sc_data_direction to
DMA_BIDIRECTIONAL; scsi_bidi_cmnd(cmd) should be used instead to
test for a bidirectional command.

[Christoph Hellwig:]  Bidirectional commands won't ever be queued
anyway, unless a LLD or transport driver sets QUEUE_FLAG_BIDI.

So, simply remove the respective queuecommand check in the SBP-2
transport driver.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/sbp2.c diff | blob | history
Pandora Kernel Repository