ARM: gic: use handle_fasteoi_irq for SPIs
authorWill Deacon <will.deacon@arm.com>
Wed, 9 Feb 2011 12:01:12 +0000 (12:01 +0000)
committerWill Deacon <will.deacon@arm.com>
Wed, 11 May 2011 15:04:17 +0000 (16:04 +0100)
commit1a01753ed90a4fb84357b9b592e50564c07737f7
tree57381deaf1267db867d154df2d8a5fb8288b003d
parent4bd66cfde5c3b6eced0da483c6357ae46d3adbb5
ARM: gic: use handle_fasteoi_irq for SPIs

Currently, the gic uses handle_level_irq for handling SPIs (Shared
Peripheral Interrupts), requiring active interrupts to be masked at
the distributor level during IRQ handling.

On a virtualised system, only the CPU interfaces are virtualised in
hardware. Accesses to the distributor must be trapped by the
hypervisor, adding latency to the critical interrupt path in Linux.

This patch modifies the GIC code to use handle_fasteoi_irq for handling
interrupts, which only requires us to signal EOI to the CPU interface
when handling is complete. Cascaded IRQ handling is also updated to use
the chained IRQ enter/exit functions to honour the flow control of the
parent chip.

Note that commit 846afbd1 ("GIC: Dont disable INT in ack callback")
broke cascading interrupts by forgetting to add IRQ masking. This is
no longer an issue because the unmask call is now unnecessary.

Tested on Versatile Express and Realview EB (1176 w/ cascaded GICs).

Tested-and-reviewed-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Tested-and-acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm/common/gic.c