batman-adv: fix random jitter calculation
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 26 Dec 2012 02:32:10 +0000 (02:32 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Dec 2012 22:13:23 +0000 (14:13 -0800)
commit143cdd8f33909ff5a153e3f02048738c5964ba26
treef702045bb91845840e7d27c69dead53d2bea1793
parentcf0be88057baceae033a82d669128b282308c742
batman-adv: fix random jitter calculation

batadv_iv_ogm_emit_send_time() attempts to calculates a random integer
in the range of 'orig_interval +- BATADV_JITTER' by the below lines.

        msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER;
        msecs += (random32() % 2 * BATADV_JITTER);

But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER'
because '%' and '*' have same precedence and associativity is
left-to-right.

This adds the parentheses at the appropriate position so that it matches
original intension.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Antonio Quartulli <ordex@autistici.org>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Antonio Quartulli <ordex@autistici.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
net/batman-adv/bat_iv_ogm.c