sched/rt: Fix SCHED_RR across cgroups
authorColin Cross <ccross@android.com>
Thu, 17 May 2012 04:34:23 +0000 (21:34 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 15 Feb 2014 19:20:17 +0000 (19:20 +0000)
commit13d8ff3f710fae656eb7c5648c1efce749bf8b52
treedc55043ea8742a807cb24aa893adb007090fbc67
parent8ae94088319ea3047cdf68adc9fafdcf862e2790
sched/rt: Fix SCHED_RR across cgroups

commit 454c79999f7eaedcdf4c15c449e43902980cbdf5 upstream.

task_tick_rt() has an optimization to only reschedule SCHED_RR tasks
if they were the only element on their rq.  However, with cgroups
a SCHED_RR task could be the only element on its per-cgroup rq but
still be competing with other SCHED_RR tasks in its parent's
cgroup.  In this case, the SCHED_RR task in the child cgroup would
never yield at the end of its timeslice.  If the child cgroup
rt_runtime_us was the same as the parent cgroup rt_runtime_us,
the task in the parent cgroup would starve completely.

Modify task_tick_rt() to check that the task is the only task on its
rq, and that the each of the scheduling entities of its ancestors
is also the only entity on its rq.

Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1337229266-15798-1-git-send-email-ccross@android.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/sched_rt.c