kgdb,x86: fix regression in detach handling
authorJason Wessel <jason.wessel@windriver.com>
Mon, 15 Nov 2010 14:07:35 +0000 (08:07 -0600)
committerJason Wessel <jason.wessel@windriver.com>
Wed, 17 Nov 2010 19:54:57 +0000 (13:54 -0600)
commit10a6e67648d4b47769953bd24759ba9609bf00df
tree87a7381db182f858bda6b275c421ee01f674b5de
parent5450d904054b4ed582793ad6ecb5469f03cc4c46
kgdb,x86: fix regression in detach handling

The fix from ba773f7c510c0b252145933926c636c439889207
(x86,kgdb: Fix hw breakpoint regression) was not entirely complete.

The kgdb_remove_all_hw_break() function also needs to call the
hw_break_release_slot() or else a breakpoint can get activated again
after the debugger has detached.

The kgdb test suite exposes the behavior in the form of either a hang
or repetitive failure.  The kernel config that exposes the problem
contains all of the following:

CONFIG_DEBUG_RODATA=y
CONFIG_KGDB_TESTS=y
CONFIG_KGDB_TESTS_ON_BOOT=y
CONFIG_KGDB_TESTS_BOOT_STRING="V1F100"

Reported-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Tested-by: Frederic Weisbecker <fweisbec@gmail.com>
arch/x86/kernel/kgdb.c