md/raid10: don't clear bitmap during recovery if array will still be degraded.
authorNeilBrown <neilb@suse.de>
Thu, 7 May 2009 02:48:10 +0000 (12:48 +1000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 20 May 2009 05:20:05 +0000 (22:20 -0700)
commit10681e946a0f05731f280406cb674bd5d8b0187c
treef622ff7bff11e72f69f1a88a046bcbab07629e07
parent47a0d1852bafea509dcec4599d72e1b662223e72
md/raid10: don't clear bitmap during recovery if array will still be degraded.

commit 18055569127253755d01733f6ecc004ed02f88d0 upstream.

If we have a raid10 with multiple missing devices, and we recover just
one of these to a spare, then we risk (depending on the bitmap and
array chunk size) clearing bits of the bitmap for which recovery isn't
complete (because a device is still missing).

This can lead to a subsequent "re-add" being recovered without
any IO happening, which would result in loss of data.

This patch takes the safe approach of not clearing bitmap bits
if the array will still be degraded.

This patch is suitable for all active -stable kernels.

Cc: stable@kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/md/raid10.c