cifs: remove bogus first_time check in NTLMv2 session setup code
authorJeff Layton <jlayton@redhat.com>
Wed, 16 Jun 2010 17:40:18 +0000 (13:40 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:18:49 +0000 (10:18 -0700)
commit0fd85ded784c60defd59d15a6a720793b4bfcad9
tree141ce1a10055e992090455035bb400fc28649230
parent4fe7e0696857ed6b1980a2e5198aa4507c1fa9e9
cifs: remove bogus first_time check in NTLMv2 session setup code

commit 8a224d489454b7457105848610cfebebdec5638d upstream.

This bug appears to be the result of a cut-and-paste mistake from the
NTLMv1 code. The function to generate the MAC key was commented out, but
not the conditional above it. The conditional then ended up causing the
session setup key not to be copied to the buffer unless this was the
first session on the socket, and that made all but the first NTLMv2
session setup fail.

Fix this by removing the conditional and all of the commented clutter
that made it difficult to see.

Reported-by: Gunther Deschner <gdeschne@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/cifs/sess.c