VFS: move BUG_ON test for symlink nd->depth after current->link_count test
authorErez Zadok <ezk@fsl.cs.sunysb.edu>
Sat, 21 May 2011 05:19:59 +0000 (01:19 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 3 Jun 2011 00:31:47 +0000 (09:31 +0900)
commit084013b8e040a1414f83e5574d2716019c180a11
tree9157d914fc8aead4f93b81e2ba0a1ff16ad473c7
parent05e9a48acf36b2b8ded09d4c630ec4671de713db
VFS: move BUG_ON test for symlink nd->depth after current->link_count test

commit 1a4022f88d40e1255920b017556092ab926d7f66 upstream.

This solves a serious VFS-level bug in nested_symlink (which was
rewritten from do_follow_link), and follows the order of depth tests
that existed before.

The bug triggers a BUG_ON in fs/namei.c:1381, when running racer with
symlink and rename ops.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
Acked-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/namei.c