bonding: don't lock when copying/clearing VLAN list on slave
authorJay Vosburgh <fubar@us.ibm.com>
Wed, 21 Jul 2010 12:14:48 +0000 (12:14 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Jul 2010 21:14:47 +0000 (14:14 -0700)
commit03dc2f4c525afb9488edb687c2e1f7057d59b40e
tree59702784f96f5a7427e4053c65845aad9a2d1d68
parentf35188faa0fbabefac476536994f4b6f3677380f
bonding: don't lock when copying/clearing VLAN list on slave

When copying VLAN information to or removing from a slave
during slave addition or removal, the bonding code currently holds
the bond->lock for write to prevent concurrent modification of the
vlan_list / vlgrp.

This is unnecessary, as all of these operations occur under
RTNL.  Holding the bond->lock also caused might_sleep issues for
some drivers' ndo_vlan_* functions.  This patch removes the extra
locking.

Problem reported by Michael Chan <mchan@broadcom.com>

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Cc: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c