regulatory: add NUL to request alpha2
authorJohannes Berg <johannes.berg@intel.com>
Thu, 22 Feb 2018 19:55:28 +0000 (20:55 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:18 +0000 (00:30 +0100)
commit 657308f73e674e86b60509a430a46e569bf02846 upstream.

Similar to the ancient commit a5fe8e7695dc ("regulatory: add NUL
to alpha2"), add another byte to alpha2 in the request struct so
that when we use nla_put_string(), we don't overrun anything.

Fixes: 73d54c9e74c4 ("cfg80211: add regulatory netlink multicast group")
Reported-by: Kees Cook <keescook@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/net/regulatory.h

index c3c22e0..068fc65 100644 (file)
@@ -66,7 +66,7 @@ enum environment_cap {
 struct regulatory_request {
        int wiphy_idx;
        enum nl80211_reg_initiator initiator;
-       char alpha2[2];
+       char alpha2[3];
        bool intersect;
        bool processed;
        enum environment_cap country_ie_env;